Add a key to CircuitContent to keep UI and Presenter consistent
#1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stagg
changed the title
key to CircuitContent to keep UI and Presenter consistent
ZacSweers
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve #1169 this keys the ui and presenter together so they behave the same.
Here's the *CircuitContent cases this covers:
1. NavigableCircuitContent
Screencan't change without a new record instance.2. CircuitContent
Screeninstance is a new "page" and would behave the same asNavigableCircuitContent, by being keyed on theScreeninstance.Screenis a model, and it's used to update the currentCircuitContentstate, as if it were another Compose element. This is potentially common with a "widget" sub-circuit case.