Check canRetainCheck when saving RetainedStateRegistry #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
commented
Mar 11, 2024
backstack/src/commonMain/kotlin/com/slack/circuit/backstack/BackStack.kt
Outdated
Show resolved
Hide resolved
chrisbanes
commented
Mar 11, 2024
backstack/src/commonMain/kotlin/com/slack/circuit/backstack/SaveableBackStack.kt
Show resolved
Hide resolved
Required propagating a generic type through NavigableCircuitContent
|
Though looks like there's a couple CI failures still |
ZacSweers
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly @alexvanyo's work from #1253. Unfortunately I couldn't find a way for a PR from a fork to be based on another PR from a different fork.
My changes add the relevant fixes to make sure that saved/restored back stacks (aka back stacks) work with the changes. Primarily this is so that we check both the current back stack and saved backstacks when determining whether we can retain state.
Fixes #1252