Make RememberObservers in nested registries work #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
commented
Mar 13, 2024
circuit-retained/src/commonMain/kotlin/com/slack/circuit/retained/RetainedStateRegistry.kt
Show resolved
Hide resolved
chrisbanes
force-pushed
the
cb/remember-observer-nested
branch
from
12290ca to
4b88b62
Compare
ZacSweers
reviewed
Mar 13, 2024
circuit-retained/src/commonMain/kotlin/com/slack/circuit/retained/RetainedStateRegistry.kt
Outdated
Show resolved
Hide resolved
ZacSweers
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
RememberObserversupport for retained state only works if it is added directly to the root retained registry. That works fine in our simple test, butNavigableCircuitContentadds a much more complex retained registry system, which uses multiple levels of registries.This PR fixes this, adding support for nested registries. I've confirmed that this works as expected in Tivi.