Remember keys in rememberSaveableBackStack #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @JustinBis to sign the Salesforce Inc. Contributor License Agreement. |
ZacSweers
approved these changes
Apr 4, 2024
auto-merge was automatically disabled
April 4, 2024 23:21
Head branch was pushed to by a user without write access
|
@ZacSweers will need another auto-merge approval, had to run the formatter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
rememberSaveableBackStackto use use the initial root screen(s) as keys.Before this, you could never get a new backstack when using
rememberSaveableBackStack. This blocks using navigable Circuits within views that may have their root screen change, such as a ComposeView in a RecyclerView or other XML layout that has data being rebound.This includes a small test suite to cover both remember cases and
NavigableCircuitContent.