Navigator - Guard against a goTo to the current screen #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Apr 12, 2024
| backStack.push(screen) | ||
| override fun goTo(screen: Screen): Boolean { | ||
| return if (peek() != screen) { | ||
| backStack.push(screen) |
There was a problem hiding this comment.
Should we mirror this in the back stack push()? I actually wonder if this would be better off as a back stack configuration
| override fun goTo(screen: Screen): Boolean { | ||
| val res = delegate.goTo(screen) | ||
| if (res) { | ||
| goToEvents.add(screen) |
There was a problem hiding this comment.
Part of me thinks this should always log but we could offer a way to read the transaction result?
There was a problem hiding this comment.
Added a GoToEvent to cover this 👍🏻
ZacSweers
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1317 with the bool result return approach. Open to also going with the passed in callback which was another suggested approach.