Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh STAR sample theming #1461

Merged
merged 13 commits into from
Jun 7, 2024
Merged

Refresh STAR sample theming #1461

merged 13 commits into from
Jun 7, 2024

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Jun 6, 2024

This does a few things

  • Regenerates the M3 themes using the updated M3 theme builder that actually supports color matching.
  • Updates the Desktop app to actually use the theme (was using M3 defaults before)
  • Incorporates use of the usual font they use
  • Incorporates use of expect/actual for the StarTheme entry point so different platforms can support different things
  • Supports dynamic theming on Android 12+
  • Fixes up a few missing retentions in the pet list to work better across the backstack
Screen_recording_20240606_212135.mp4

This does a few things
- Regenerates the M3 themes using the updated M3 theme builder that actually supports color matching.
- Updates the Desktop app to actually use the theme (was using M3 defaults before)
- Incorporates use of the usual font they use
- Incorporates use of expect/actual for the StarTheme entry point so different platforms can support different things
@ZacSweers ZacSweers requested a review from stagg June 6, 2024 20:21
@ZacSweers ZacSweers added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 58fee1c Jun 7, 2024
6 checks passed
@ZacSweers ZacSweers deleted the z/refreshThemes branch June 7, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants