Updated STAR demo to support navigating to standard Android

samples/star/build.gradle.kts

@@ -32,7 +32,7 @@ android {
   defaultConfig {
     minSdk = 28
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    testApplicationId = "com.slack.circuit.star.androidTest"
+    testApplicationId = "com.slack.circuit.star.apk.androidTest"
   }
 
   testOptions { unitTests.isIncludeAndroidResources = true }
@@ -115,7 +115,7 @@ dependencies {
   testImplementation(libs.androidx.compose.ui.testing.manifest)
   testImplementation(libs.leakcanary.android.instrumentation)
 
-  debugImplementation(libs.androidx.compose.ui.testing.manifest)
+  androidTestImplementation(libs.androidx.compose.ui.testing.manifest)
   androidTestImplementation(libs.leakcanary.android.instrumentation)
   androidTestImplementation(libs.androidx.compose.ui.testing.junit)
   androidTestImplementation(libs.junit)

samples/star/src/androidTest/kotlin/com/slack/circuit/star/petdetail/PetDetailTest.kt

@@ -21,6 +21,7 @@ import androidx.compose.ui.test.assertTextEquals
 import androidx.compose.ui.test.junit4.createAndroidComposeRule
 import androidx.compose.ui.test.onNodeWithTag
 import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.performClick
 import androidx.compose.ui.test.performTouchInput
 import androidx.compose.ui.test.swipeUp
 import androidx.test.platform.app.InstrumentationRegistry
@@ -30,10 +31,13 @@ import com.slack.circuit.CircuitCompositionLocals
 import com.slack.circuit.CircuitConfig
 import com.slack.circuit.star.R
 import com.slack.circuit.star.petdetail.PetDetailTestConstants.ANIMAL_CONTAINER_TAG
+import com.slack.circuit.star.petdetail.PetDetailTestConstants.FULL_BIO_TAG
 import com.slack.circuit.star.petdetail.PetDetailTestConstants.PROGRESS_TAG
 import com.slack.circuit.star.petdetail.PetDetailTestConstants.UNKNOWN_ANIMAL_TAG
 import com.slack.circuit.star.petdetail.PetPhotoCarouselTestConstants.CAROUSEL_TAG
 import com.slack.circuit.star.ui.FakeImageLoader
+import kotlinx.coroutines.channels.Channel
+import kotlinx.coroutines.test.runTest
 import leakcanary.DetectLeaksAfterTestSuccess.Companion.detectLeaksAfterTestSuccessWrapping
 import org.junit.Before
 import org.junit.Rule
@@ -93,6 +97,7 @@ class PetDetailTest {
         name = "Baxter",
         description = "Grumpy looking Australian Terrier",
         tags = listOf("dog", "terrier", "male"),
+        eventSink = {}
       )
 
     var carouselScreen: PetPhotoCarouselScreen? = null
@@ -127,4 +132,37 @@ class PetDetailTest {
       }
     }
   }
+
+  @Test
+  fun petDetail_emits_event_when_tapping_on_full_bio_button() = runTest {
+    val channel = Channel<Any>(1)
+
+    val success =
+      PetDetailScreen.State.Success(
+        url = "url",
+        photoUrls = listOf("http://some.url"),
+        photoUrlMemoryCacheKey = null,
+        name = "Baxter",
+        description = "Grumpy looking Australian Terrier",
+        tags = listOf("dog", "terrier", "male"),
+        eventSink = channel::trySend
+      )
+
+    val circuitConfig =
+      CircuitConfig.Builder()
+        .setOnUnavailableContent { screen ->
+          PetPhotoCarousel(PetPhotoCarouselScreen.State(screen as PetPhotoCarouselScreen))
+        }
+        .build()
+
+    composeTestRule.run {
+      setContent { CircuitCompositionLocals(circuitConfig) { PetDetail(success) } }
+
+      onNodeWithTag(CAROUSEL_TAG).assertIsDisplayed().performTouchInput { swipeUp() }
+      onNodeWithTag(FULL_BIO_TAG, true).assertIsDisplayed().performClick()
+
+      val event = channel.receive()
+      assertThat(event).isEqualTo(PetDetailScreen.Event.ViewFullBio(success.url))
+    }
+  }
 }

samples/star/src/main/kotlin/com/slack/circuit/star/MainActivity.kt

@@ -16,11 +16,17 @@
 package com.slack.circuit.star
 
 import android.app.Activity
+import android.net.Uri
 import android.os.Bundle
 import androidx.activity.compose.setContent
 import androidx.appcompat.app.AppCompatActivity
+import androidx.browser.customtabs.CustomTabColorSchemeParams
+import androidx.browser.customtabs.CustomTabsIntent
+import androidx.browser.customtabs.CustomTabsIntent.COLOR_SCHEME_DARK
+import androidx.browser.customtabs.CustomTabsIntent.COLOR_SCHEME_LIGHT
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Surface
+import androidx.compose.runtime.remember
 import androidx.lifecycle.ViewModelProvider
 import com.slack.circuit.CircuitCompositionLocals
 import com.slack.circuit.CircuitConfig
@@ -33,6 +39,8 @@ import com.slack.circuit.rememberCircuitNavigator
 import com.slack.circuit.star.di.ActivityKey
 import com.slack.circuit.star.di.AppScope
 import com.slack.circuit.star.home.HomeScreen
+import com.slack.circuit.star.navigator.AndroidScreen
+import com.slack.circuit.star.navigator.LegacyNavigator
 import com.slack.circuit.star.petdetail.PetDetailScreen
 import com.slack.circuit.star.ui.StarTheme
 import com.squareup.anvil.annotations.ContributesMultibinding
@@ -63,7 +71,9 @@ constructor(
         // TODO why isn't the windowBackground enough so we don't need to do this?
         Surface(color = MaterialTheme.colorScheme.background) {
           val backstack = rememberSaveableBackStack { backStack.forEach { screen -> push(screen) } }
-          val navigator = rememberCircuitNavigator(backstack)
+          val circuitNavigator = rememberCircuitNavigator(backstack)
+          val navigator =
+            remember(circuitNavigator) { LegacyNavigator(circuitNavigator, this::goTo) }
           CircuitCompositionLocals(circuitConfig) {
             ContentWithOverlays { NavigableCircuitContent(navigator, backstack) }
           }
@@ -75,4 +85,20 @@ constructor(
   override fun getDefaultViewModelProviderFactory(): ViewModelProvider.Factory {
     return viewModelProviderFactory
   }
+
+  private fun goTo(screen: AndroidScreen) =
+    when (screen) {
+      is AndroidScreen.CustomTabsIntentScreen -> goTo(screen)
+      is AndroidScreen.IntentScreen -> TODO()
+    }
+
+  private fun goTo(screen: AndroidScreen.CustomTabsIntentScreen) {
+    val scheme = CustomTabColorSchemeParams.Builder().setToolbarColor(0x000000).build()
+    CustomTabsIntent.Builder()
+      .setColorSchemeParams(COLOR_SCHEME_LIGHT, scheme)
+      .setColorSchemeParams(COLOR_SCHEME_DARK, scheme)
+      .setShowTitle(true)
+      .build()
+      .launchUrl(this, Uri.parse(screen.url))
+  }
 }

samples/star/src/main/kotlin/com/slack/circuit/star/navigator/LegacyNavigator.kt

@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2022 Slack Technologies, LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.slack.circuit.star.navigator
+
+import android.content.Intent
+import com.slack.circuit.Navigator
+import com.slack.circuit.Screen
+import kotlinx.parcelize.Parcelize
+
+class LegacyNavigator(
+  private val navigator: Navigator,
+  private val onAndroidScreen: (AndroidScreen) -> Unit
+) : Navigator by navigator {
+  override fun goTo(screen: Screen) =
+    when (screen) {
+      is AndroidScreen -> onAndroidScreen(screen)
+      else -> navigator.goTo(screen)
+    }
+}
+
+sealed interface AndroidScreen : Screen {
+  @Parcelize data class CustomTabsIntentScreen(val url: String) : AndroidScreen
+  @Parcelize data class IntentScreen(val intent: Intent) : AndroidScreen
+}