Clean up HomeScreen nav example #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're working on a more fleshed out example of composite presenters, so cleaning this one up as it's sort of fallen out of date.
kierse
reviewed
Mar 1, 2023
Comment on lines
13
to
16
| class HomeNavState { | ||
| val navItems: ImmutableList<BottomNavItem> = | ||
| persistentListOf(BottomNavItem.Adoptables, BottomNavItem.About) | ||
| var index by mutableStateOf(0) |
There was a problem hiding this comment.
Any reason why we couldn't simplify this further and pass the screen down to the UI instead of using BottomNavItem? Both Adoptables and About are 0 simple objects making this indirection feel like unnecessary boilerplate
There was a problem hiding this comment.
I don't think the separation is bad in this case tbh, vs stuffing it into the home screen state
kierse
approved these changes
Mar 1, 2023
|
uhhh what happened to this test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working on a more fleshed out example of composite presenters, so cleaning this one up as it's sort of fallen out of date.