-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial iOS support #583
Merged
Initial iOS support #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently stuck on JetBrains/compose-multiplatform#3088 with the iOS Counter app sample, but everything else looks like it's working. Wanna clean up some of the repetitive bits |
Too many issues in KMM
Once #615 is in, then we don't need to maintain the separate |
kierse
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does an initial integration of support for iOS in our core artifacts. This is very much intended just to be a toe-hold and not anything meaningful or commitment, but rather a step similar to when we first moved into multiplatform where it can help keep the door open for later work by keeping us honest in our implementation of circuit internals cross-platform friendly now.
This does a bunch of that ground work, namely around preparing the
counter
sample for this and making some needed infra changes in the core artifacts to support it.ios
(which includesiosX64
andiosArm64
) andiosSimulatorArm64
(needed for simulator runs) in projects +actual
declarations where neededScreen
will look like in iOS. There'sNSCoder
maybe? Saving for future work.ContentWithOverlays
tocommonMain
.rememberRetained
is also inert like on JVM.Counter
app and dir. This is super basic and uses a KMM circuit presenter + SwiftUI. It does not try to do a fullCircuitContent
or anything related. Most relevant bits are inContentView.swift
andSwiftSupport.kt
.Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-04-29.at.13.50.12.mp4