Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Compile SDK 34 #676

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Update to Compile SDK 34 #676

merged 2 commits into from
Jun 15, 2023

Conversation

ZacSweers
Copy link
Collaborator

No description provided.

@ZacSweers ZacSweers requested a review from kierse June 10, 2023 02:11
@ZacSweers
Copy link
Collaborator Author

I think it's ok if we build against this even if Slack itself hasn't yet, but we should double check.

@ZacSweers
Copy link
Collaborator Author

Checked and not ok to compile against 34 and use it in an app compiled against 33. As such I've changed this to only use 34 in samples for now

@ZacSweers ZacSweers enabled auto-merge June 15, 2023 01:32
@ZacSweers ZacSweers added this pull request to the merge queue Jun 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 15, 2023
@ZacSweers ZacSweers merged commit cfcb6e6 into main Jun 15, 2023
@ZacSweers ZacSweers deleted the z/sdk34 branch June 15, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kierse kierse kierse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacSweers @kierse