Remove intermediate event sinks #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can no longer reproduce the original issue. While the recomposition factor does come into play, this seems more or less acceptable that the recomposition can happen when the state updates. This simplifies our usage a fair bit, and I kind of wonder if the original bug was something else wrong with the compose code we'd written at the time. I think we should run ahead with this until/unless we see reproducible issues with it.
kierse
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can no longer reproduce the original issue. While the recomposition factor does come into play, this seems more or less acceptable that the recomposition can happen when the state updates. This simplifies our usage a fair bit, and I kind of wonder if the original bug was something else wrong with the compose code we'd written at the time. I think we should run ahead with this until/unless we see reproducible issues with it.