Promote Screen to BackStack proper APIs #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really just want to replace route with the Screen, not much else
ZacSweers
changed the title
ashdavies
pushed a commit
to ashdavies/circuit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some long-overdue work to promote
ScreentoBackStackand replace theRecord.routeproperty. This, along with promoting someSaveableBackStackAPIs up toBackStack, allows us to finally generalize the backstack inputs toNavigableBackStackelsewhere.This requires moving
Screenout to its own artifact as a part of this.The runtime still directly depends on
Screenfor now to allow an easier migration, but longer term this'll just be backstack and foundation deps.Resolves #827. CC @chrisbanes