Upstream some navigation improvements from Tivi #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst arg This allows for more complex backstack nav handling, such as predictive back gestures
chrisbanes
approved these changes
Aug 30, 2023
|
Looks good! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
This is a port of functionality which I've been using in [Tivi](https://github.com/chrisbanes/tivi) for a while now. With the recent changes in #835, this unlocks the path way it upstreaming them as a new CircuitX library. - I've updated the CircuitX docs below, so that contains all of the necessary information. - Migrated the Star sample to using this - Migrate Tivi to use this (via `mavenLocal`) in chrisbanes/tivi#1494 and everything is working nicely.
ashdavies
pushed a commit
to ashdavies/circuit
that referenced
this pull request
Sep 14, 2023
Borrowing from https://github.com/chrisbanes/tivi/blob/main/ui/root/src/commonMain/kotlin/app/tivi/home/NavigableCircuitContentWithPrevious.kt after working with @chrisbanes This brings in two important changes - Pass the whole list of records to `DecoratedContent`, allowing more complex handling of back gestures (predictive back in android, drag gestures in iOS, etc) - Refactor out a `buildCircuitContentProviders()`, which enables `movableContentOf` to work since it's reusing the same instance for records across changes. Along the way this promotes immutable collections to the first part API for compose stability
ashdavies
pushed a commit
to ashdavies/circuit
that referenced
this pull request
Sep 14, 2023
This is a port of functionality which I've been using in [Tivi](https://github.com/chrisbanes/tivi) for a while now. With the recent changes in slackhq#835, this unlocks the path way it upstreaming them as a new CircuitX library. - I've updated the CircuitX docs below, so that contains all of the necessary information. - Migrated the Star sample to using this - Migrate Tivi to use this (via `mavenLocal`) in chrisbanes/tivi#1494 and everything is working nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowing from https://github.com/chrisbanes/tivi/blob/main/ui/root/src/commonMain/kotlin/app/tivi/home/NavigableCircuitContentWithPrevious.kt after working with @chrisbanes
This brings in two important changes
DecoratedContent, allowing more complex handling of back gestures (predictive back in android, drag gestures in iOS, etc)buildCircuitContentProviders(), which enablesmovableContentOfto work since it's reusing the same instance for records across changes.Along the way this promotes immutable collections to the first part API for compose stability