Optimize rememberRetained #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of the analogous change in `rememberSaveable` in compose 1.6.0 alphas: https://android-review.googlesource.com/c/platform/frameworks/support/+/2655245 Note that we have to introduce a `RetainedValueProvider` option to support JS.
chrisbanes
approved these changes
Sep 4, 2023
ZacSweers
commented
Sep 4, 2023
| @@ -2,7 +2,7 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| @file:Suppress("INVISIBLE_MEMBER", "INVISIBLE_REFERENCE") | |||
|
|
|||
| package com.circuit.retained.android | |||
| package com.slack.circuit.retained.android | |||
There was a problem hiding this comment.
opportunistic fix
ashdavies
pushed a commit
to ashdavies/circuit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the analogous change in
rememberSaveablein compose 1.6.0 alphas: https://android-review.googlesource.com/c/platform/frameworks/support/+/2655245Note that we have to introduce a
RetainedValueProvideroption to support JS.Resolves #849