Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Kotlin 1.9.20 #889

Merged
merged 32 commits into from
Oct 31, 2023
Merged

Update to Kotlin 1.9.20 #889

merged 32 commits into from
Oct 31, 2023

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Sep 20, 2023 •
edited
Loading

  • CM 1.5.10
  • compose compiiler 1.5.4-dev-k1.9.20-50f08dfa4b4
  • CM compiler 1.5.3
  • kotlin 1.9.20
  • KSP 1.9.20-1.0.13

@ZacSweers
Copy link
Collaborator Author

The new limitations to supertypes in expect/actual interfaces is pretty busted for Screen, I don't see how this is supposed to work now. It feels like this more or less makes expect/actual interfaces useless in KMP?

@ZacSweers
Merge branch 'main' into z/kotlin1920
081a8a9
@ZacSweers
Merge branch 'main' into z/kotlin1920
04f2583
@ZacSweers
Remove leftover deleted one
a6a0db9
@ZacSweers
Suppress it for now
58f0851
@ZacSweers
Restructure TestEventSink for new limitations :(
1450bdd
@ZacSweers
Merge branch 'main' into z/kotlin1920
2e6968d
@ZacSweers
Suppress deprecation for now
9128eac
@ZacSweers
Use replacement
1471c58
@ZacSweers
Demo kotlin 1.9.20 issue with KT-21846 (#921)
a8227c9 
https://youtrack.jetbrains.com/issue/KT-21846

```
> Task :circuit-test:compileKotlinIosSimulatorArm64 FAILED
e: file:///Users/zacsweers/dev/slack/oss/circuit/circuit-test/src/iosMain/kotlin/com/slack/circuit/test/TestEventSink.ios.kt:5:1 Actual interface 'BaseTestEventSinkType': actual class and its non-final expect class must declare exactly the same supertypes. Actual class declares the following supertypes that are not presented in expect class: 'Function1'. This error happens because the expect class 'BaseTestEventSinkType' is non-final. Also see https://youtrack.jetbrains.com/issue/KT-22841 for more details

```
@ZacSweers
Merge branch 'main' into z/kotlin1920
4727296
@ZacSweers
RC2 updates
6132e5e
@ZacSweers
Merge branch 'main' into z/kotlin1920
ffd8dc2
@ZacSweers
No RC2 for KSP yet
2161214
@ZacSweers
Revert compilerOptions usages
186695e
@ZacSweers
Restore RetainedValueProvider setup
68bcd2d
@ZacSweers
Restore Screen
4b12c26
@ZacSweers
Restore more
5f3fe73
@ZacSweers
Spotless
3531bd2
@ZacSweers
Copy link
Collaborator Author

Yessss they changed course and are supporting actualizing more supertypes 🥳

@ZacSweers ZacSweers requested review from kierse and stagg October 31, 2023 21:03
@ZacSweers ZacSweers marked this pull request as ready for review October 31, 2023 21:03
@ZacSweers ZacSweers changed the title Prepare for Kotlin 1.9.20 Update to Kotlin 1.9.20 Oct 31, 2023
@ZacSweers ZacSweers enabled auto-merge October 31, 2023 21:09
@ZacSweers ZacSweers added this pull request to the merge queue Oct 31, 2023
stagg
stagg approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@stagg stagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Merged via the queue into main with commit c1544ca Oct 31, 2023
@ZacSweers ZacSweers deleted the z/kotlin1920 branch October 31, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stagg stagg stagg approved these changes

@kierse kierse Awaiting requested review from kierse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacSweers @stagg