Workaround disallow changes by splitting configuration file setup #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Apr 18, 2024
|
Thanks! Sorry for the delay, I didn't see this |
|
any plans on getting this one released anytime soon? or are there snapshots we can use to test the fix? |
|
It would also be really great for us if we there would be a release with this fix, thanks! |
|
The fix no longer appears to work #141. Sorry but I'm not sure what can be done about it at this point. In the meantime, please be respectful of OSS maintainers and don't nag for releases of something you could build yourself: https://www.zacsweers.dev/you-are-not-blocked/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a potential workaround for #135 by taking advantage of the configuration split for
disableTestProguardFiles.I don't think the main configuration has to wait for
afterEvaluate- it wasn't inafterEvaluateprior to #117, so maybe we can move that part out ofafterEvaluateto avoid running into thedisallowChangesissue.If
disableTestProguardFilesis nottrue, then the newdisallowChanges()will still cause the #135 issue, but on the latest AGP versions not specifyingdisableTestProguardFileswon't work anyway.I validated this change locally against alexvanyo/composelife#1500 updating
8.4.0-alpha04to8.4.0-alpha11.