New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: fix dropped error #1002

Merged

wadey merged 1 commit into slackhq:master from alrs:ssh-err

Oct 31, 2023

Contributor

alrs commented Oct 27, 2023

This fixes a dropped err variable in the nebula package


          main: fix dropped error

e13f40b

salesforce-cla bot added the cla:signed label

wadey added this to the v1.8.0 milestone

Member

wadey commented Oct 31, 2023

This isn't an actual issue because the current implementation of NewSSHServer never returns an error (https://github.com/slackhq/nebula/blob/v1.7.2/sshd/server.go#L56), but still good to fix so no surprises happen in the future. Thanks.

wadey approved these changes

View reviewed changes

wadey merged commit 77a8ce1 into slackhq:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels