Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add puncuation to doc comment #1164

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

jasikpark
Copy link
Collaborator

@jasikpark jasikpark commented Jun 13, 2024

This change improves reading of the doc comment after it's been consumed by the Golang LSP:

Before:

image

After:

image

@wadey wadey added this to the v1.10.0 milestone Jun 24, 2024
@wadey wadey merged commit 8109cf2 into slackhq:master Jun 24, 2024
8 checks passed
@jasikpark jasikpark deleted the fix-formatting-in-comment branch June 24, 2024 18:50
@wadey wadey modified the milestones: v1.10.0, v1.9.4 Sep 3, 2024
wadey added a commit that referenced this pull request Sep 3, 2024
Non dependency changes:

- #1194
- #1191
- #1188
- #1185
- #1181
- #1173
- #1171
- #1164
- #1162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants