Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have lighthouses ack updates to reduce test packet traffic #851

Merged
merged 2 commits into from
May 5, 2023

Conversation

nbrownus
Copy link
Collaborator

@nbrownus nbrownus commented Apr 20, 2023

This change has the lighthouse send an ack packet on the lighthouse message type after receiving an update. The goal is to get some return traffic on the line so the client doesn't have to always send test packets to determine if the lighthouse is still alive.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @nbrownus to sign the Salesforce.com Contributor License Agreement.

examples/config.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me 😁

@wadey wadey added this to the v1.7.0 milestone Apr 24, 2023
jasikpark
jasikpark previously approved these changes May 4, 2023
Copy link
Collaborator

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nbrownus nbrownus changed the title Make testing lighthouses optional Have lighthouses ack updates to reduce test packet traffic May 5, 2023
@nbrownus nbrownus merged commit 48eb638 into master May 5, 2023
@nbrownus nbrownus deleted the lh-test-option branch May 5, 2023 19:44
apeters1827 pushed a commit to oneclick-ag/nebula that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants