Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetrofitUsage should allow Unit return types for suspend functions #239

Open
ZacSweers opened this issue Feb 26, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@ZacSweers
Copy link
Collaborator

No description provided.

@ZacSweers ZacSweers added the bug Something isn't working label Feb 26, 2024
@oguzcelik
Copy link

I came to report this. For some cases we don't care about the response of the call and we don't define a return type like:

interface SomeService {

    @Suppress("RetrofitUsage")
    @DELETE("someEndpoint")
    suspend fun someRequest()
}

and it is a valid case. We decided to suppress this issue for now and open a report but I see you have already opened the issue 🚀

@ZacSweers
Copy link
Collaborator Author

PR welcome!

@oguzcelik
Copy link

oguzcelik commented Jul 8, 2024

Here we go 🚀 #293

It's funny that the issue is #239 and the pr is #293 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants