Update to Lint 31.4.0 alphas + improve repo infra

gradle.properties

@@ -21,6 +21,10 @@ org.gradle.configureondemand=true
 org.gradle.caching=true
 org.gradle.configuration-cache=true
 
+android.suppressUnsupportedOptionWarnings=android.suppressUnsupportedOptionWarnings,\
+  android.experimental.lint.missingBaselineIsEmptyBaseline
+android.experimental.lint.missingBaselineIsEmptyBaseline=true
+
 # Versioning bits
 GROUP=com.slack.lint
 POM_URL=https://github.com/slackhq/slack-lints/

gradle/libs.versions.toml

@@ -5,13 +5,13 @@ jdk = "21"
 # lint checks must target JDK 17, but the runtime should remain 11
 lintJvmTarget = "17"
 runtimeJvmTarget = "11"
-lint = "31.3.0-rc01"
+lint = "31.4.0-alpha07"
 
 [plugins]
 buildConfig = { id = "com.github.gmazzo.buildconfig", version = "5.3.5" }
 detekt = { id = "io.gitlab.arturbosch.detekt", version = "1.23.5" }
 dokka = { id = "org.jetbrains.dokka", version = "1.9.10" }
-lint = { id = "com.android.lint", version = "8.2.2" }
+lint = { id = "com.android.lint", version = "8.4.0-alpha07" }
 kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
 ksp = { id = "com.google.devtools.ksp", version = "1.9.22-1.0.17" }
 mavenPublish = { id = "com.vanniktech.maven.publish", version = "0.27.0" }

slack-lint-checks/build.gradle.kts

@@ -41,6 +41,8 @@ val shade: Configuration = configurations.maybeCreate("compileShaded")
 
 configurations.getByName("compileOnly").extendsFrom(shade)
 
+tasks.test { maxParallelForks = Runtime.getRuntime().availableProcessors() * 2 }
+
 dependencies {
   compileOnly(libs.bundles.lintApi)
   ksp(libs.autoService.ksp)

slack-lint-checks/src/main/java/slack/lint/MoshiUsageDetector.kt

@@ -142,7 +142,7 @@ class MoshiUsageDetector : Detector(), SourceCodeScanner {
         // and we choose to ignore it in that case.
         // This can sometimes come back as the default empty String and sometimes as null if not
         // defined
-        val generatorExpression = jsonClassAnnotation.findAttributeValue("generator")
+        val generatorExpression = jsonClassAnnotation.findDeclaredAttributeValue("generator")
         val generator = generatorExpression?.evaluate() as? String
         if (generator != null) {
           if (generator.isBlank()) {

slack-lint-checks/src/main/java/slack/lint/SlackIssueRegistry.kt

@@ -53,7 +53,6 @@ class SlackIssueRegistry : IssueRegistry() {
     add(ErrorProneDoNotMockDetector.ISSUE)
     addAll(MoshiUsageDetector.issues())
     addAll(FragmentDaggerFieldInjectionDetector.issues)
-    addAll(InjectWithUsageDetector.ISSUES)
     addAll(RedactedUsageDetector.ISSUES)
     add(InjectInJavaDetector.ISSUE)
     add(RetrofitUsageDetector.ISSUE)

slack-lint-checks/src/main/java/slack/lint/retrofit/RetrofitUsageDetector.kt

@@ -62,7 +62,8 @@ class RetrofitUsageDetector : Detector(), SourceCodeScanner {
         }
 
         val hasPath =
-          (httpAnnotation.findAttributeValue("value")?.evaluate() as? String)?.isNotBlank() ?: false
+          (httpAnnotation.findDeclaredAttributeValue("value")?.evaluate() as? String)?.isNotBlank()
+            ?: false
 
         var hasBodyParam = false
         var hasFieldParams = false