hacked 9152.patch

go/vt/discovery/healthcheck.go

@@ -288,7 +288,7 @@ func NewHealthCheck(ctx context.Context, retryDelay, healthCheckTimeout time.Dur
 	var topoWatchers []*TopologyWatcher
 	var filter TabletFilter
 	cells := strings.Split(cellsToWatch, ",")
-	if len(cells) == 0 {
+	if cellsToWatch == "" {
 		cells = append(cells, localCell)
 	}
 	for _, c := range cells {
@@ -319,7 +319,7 @@ func NewHealthCheck(ctx context.Context, retryDelay, healthCheckTimeout time.Dur
 
 	// start the topo watches here
 	for _, tw := range hc.topoWatchers {
-		go tw.Start()
+		tw.Start()
 	}
 
 	return hc

go/vt/discovery/topology_watcher.go

@@ -125,17 +125,19 @@ func NewCellTabletsWatcher(ctx context.Context, topoServer *topo.Server, tr Tabl
 // Start starts the topology watcher
 func (tw *TopologyWatcher) Start() {
 	tw.wg.Add(1)
-	defer tw.wg.Done()
-	ticker := time.NewTicker(tw.refreshInterval)
-	defer ticker.Stop()
-	for {
-		tw.loadTablets()
-		select {
-		case <-tw.ctx.Done():
-			return
-		case <-ticker.C:
+	go func() {
+		defer tw.wg.Done()
+		ticker := time.NewTicker(tw.refreshInterval)
+		defer ticker.Stop()
+		for {
+			tw.loadTablets()
+			select {
+			case <-tw.ctx.Done():
+				return
+			case <-ticker.C:
+			}
 		}
-	}
+	}()
 }
 
 // Stop stops the watcher. It does not clean up the tablets added to LegacyTabletRecorder.

go/vt/vtgate/tabletgateway_test.go

@@ -107,7 +107,8 @@ func TestTabletGatewayBeginExecuteBatch(t *testing.T) {
 }
 
 func TestTabletGatewayShuffleTablets(t *testing.T) {
-	tg := NewTabletGateway(context.Background(), nil, nil, "local")
+	hc := discovery.NewFakeHealthCheck(nil)
+	tg := NewTabletGateway(context.Background(), hc, nil, "local")
 
 	ts1 := &discovery.TabletHealth{
 		Tablet:  topo.NewTablet(1, "cell1", "host1"),