Skip to content

Commit

Permalink
improve skip logic in TestSemiSyncUpgradeDowngrade
Browse files Browse the repository at this point in the history
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
  • Loading branch information
timvaillancourt committed Feb 18, 2025
1 parent 4784d9c commit 6e63a87
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions go/test/endtoend/reparent/semisync/semi_sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ import (
)

func TestSemiSyncUpgradeDowngrade(t *testing.T) {
if utils.BinaryIsAtLeastAtVersion(20, "vttablet") {

Check failure on line 31 in go/test/endtoend/reparent/semisync/semi_sync_test.go

View workflow job for this annotation

GitHub Actions / Run Semi Sync Upgrade Downgrade Test

undefined: utils.BinaryIsAtLeastAtVersion

Check failure on line 31 in go/test/endtoend/reparent/semisync/semi_sync_test.go

View workflow job for this annotation

GitHub Actions / Static Code Checks Etc

undefined: utils.BinaryIsAtLeastAtVersion
t.Skip("We only want to run this test for >= v20 vttablet")
}
if utils.BinaryIsAtLeastAtVersion(20, "vttabletold") {

Check failure on line 34 in go/test/endtoend/reparent/semisync/semi_sync_test.go

View workflow job for this annotation

GitHub Actions / Run Semi Sync Upgrade Downgrade Test

undefined: utils.BinaryIsAtLeastAtVersion

Check failure on line 34 in go/test/endtoend/reparent/semisync/semi_sync_test.go

View workflow job for this annotation

GitHub Actions / Static Code Checks Etc

undefined: utils.BinaryIsAtLeastAtVersion (typecheck)
t.Skip("We only want to run this test for >= v20 vttablet")
}

ver, err := cluster.GetMajorVersion("vtgate")
require.NoError(t, err)
if ver != 21 {
Expand Down

0 comments on commit 6e63a87

Please sign in to comment.