Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-vitess-r12.0.5: allow conn overrides in consul topo #107

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Jul 26, 2023

Description

This PR allows overrides to http.Transport settings of the Consul topo client

This is to help address crashes we're seeing when too many consul connections are opened by vtctld

vtctld --help:

tvaillancourt@tvailla-ltmxctu vitess % ./vtctld --help 2>&1|grep -A1 topo_consul
  -topo_consul_idle_conn_timeout duration
    	Maximum amount of time to pool idle connections. (default 1m30s)
  -topo_consul_lock_delay duration
    	LockDelay for consul session. (default 15s)
  -topo_consul_lock_session_checks string
    	List of checks for consul session. (default "serfHealth")
  -topo_consul_lock_session_ttl string
    	TTL for consul session.
  -topo_consul_max_conns_per_host int
    	Maximum number of consul connections per host.
  -topo_consul_max_idle_conns int
    	Maximum number of idle consul connections. (default 100)
  -topo_consul_watch_poll_duration duration
    	time of the long poll for watch queries. (default 30s)

cc @rvrangel

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title slack-vitess-r12.0.5: allow conn overrides in consul topo slack-vitess-r12.0.5: allow conn overrides in consul topo Jul 26, 2023
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Copy link
Member Author

Replacing this PR with #108 because CI seems stuck

@timvaillancourt timvaillancourt deleted the consul-http-transport-flags-slack-vitess-r12.0.5 branch July 27, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants