-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slack-vitess-r14.0.5
: remove legacy sharding, add MySQL 8.x backup test + compressors
#119
slack-vitess-r14.0.5
: remove legacy sharding, add MySQL 8.x backup test + compressors
#119
Conversation
* Delete all legacy sharding related code Signed-off-by: Matt Lord <mattalord@gmail.com> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtctl commands Signed-off-by: Matt Lord <mattalord@gmail.com> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <mattalord@gmail.com> * WaitForDrain related stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Legacy local straggler workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtworker stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Update throttlerservice protobuf Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <mattalord@gmail.com> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct vtgate help output Signed-off-by: Matt Lord <mattalord@gmail.com>
* cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * generate vtadmin files Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Merge from main Signed-off-by: Arvind Murty <arvind.murty@gmail.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Thanks for the contribution! Before we can merge this, we need @mattlord @arvind-murty to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
I've confirmed our tvaillancourt@tvailla-ltmxctu vtops % git grep SplitClone
vendor/vitess.io/vitess/go/vt/binlog/binlogplayer/binlog_player.go:// workflow: documents the creator/manager of the stream. Example: 'SplitClone'.
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go:// SplitClone initiates a SplitClone workflow.
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go:func (wr *Wrangler) SplitClone(ctx context.Context, keyspace string, from, to []string) error {
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go: cmd := binlogplayer.CreateVReplicationState("VSplitClone", bls, "", binlogplayer.BlpStopped, primary.DbName())
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go:// VerticalSplitClone initiates a VerticalSplitClone workflow.
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go:func (wr *Wrangler) VerticalSplitClone(ctx context.Context, fromKeyspace, toKeyspace string, tables []string) error {
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go: cmd := binlogplayer.CreateVReplicationState("VSplitClone", bls, "", binlogplayer.BlpStopped, primary.DbName())
vendor/vitess.io/vitess/go/vt/wrangler/keyspace.go: return nil, nil, fmt.Errorf("neither Shard '%v' nor Shard '%v' have a 'SourceShards' entry. Did you successfully run vtworker SplitClone before? Or did you already migrate the MASTER type?", os.Left[0].ShardName(), os.Right[0].ShardName()) |
…test.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
a8e1746
to
55062ac
Compare
vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * go mod tidy + comments Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add copyright notices Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add support for builtin engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing linter errors Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing lint warning Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing test failure Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing un-necessary test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing code review feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing typos in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing flag name typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com>
* Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add 8.0 workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * whitespace Signed-off-by: Matt Lord <mattalord@gmail.com> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove extraneous changes Signed-off-by: Matt Lord <mattalord@gmail.com> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <mattalord@gmail.com> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <mattalord@gmail.com> * Specify stream type everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove repeated server install Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar... Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <mattalord@gmail.com> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <mattalord@gmail.com> * Test increasing timeout at another level Signed-off-by: Matt Lord <mattalord@gmail.com> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Bump it more :( Signed-off-by: Matt Lord <mattalord@gmail.com> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <mattalord@gmail.com> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <mattalord@gmail.com> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly skip new linter check Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Thanks for the contribution! Before we can merge this, we need @mattlord @arvind-murty @rsajwani to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
…tessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web_build to compile production files Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove vars from test Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <notfelineit@gmail.com>
Thanks for the contribution! Before we can merge this, we need @notfelineit @mattlord @arvind-murty @rsajwani to sign the Salesforce Inc. Contributor License Agreement. |
slack-vitess-r14.0.5
: remove legacy shardingslack-vitess-r14.0.5
: remove legacy sharding, add MySQL 8.x backup test + compressors
A note: the |
with: | ||
go-version: 1.19.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maksimov these backports change go-version
from 1.19.3
-> 1.18.7
. Were these changes you added and do we need to keep them? 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to keep it at 1.19.3+ for security vulnerabilities, but it's better to double check with Stas once he's back.
…test + compressors (#119) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code Signed-off-by: Matt Lord <mattalord@gmail.com> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtctl commands Signed-off-by: Matt Lord <mattalord@gmail.com> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <mattalord@gmail.com> * WaitForDrain related stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Legacy local straggler workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtworker stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Update throttlerservice protobuf Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <mattalord@gmail.com> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct vtgate help output Signed-off-by: Matt Lord <mattalord@gmail.com> * go fmt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * generate vtadmin files Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Merge from main Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Fix bad merge conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix missing 'sharding' import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * go mod tidy + comments Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add copyright notices Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add support for builtin engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing linter errors Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing lint warning Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing test failure Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing un-necessary test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing code review feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing typos in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing flag name typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add 8.0 workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * whitespace Signed-off-by: Matt Lord <mattalord@gmail.com> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove extraneous changes Signed-off-by: Matt Lord <mattalord@gmail.com> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <mattalord@gmail.com> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <mattalord@gmail.com> * Specify stream type everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove repeated server install Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar... Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <mattalord@gmail.com> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <mattalord@gmail.com> * Test increasing timeout at another level Signed-off-by: Matt Lord <mattalord@gmail.com> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Bump it more :( Signed-off-by: Matt Lord <mattalord@gmail.com> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <mattalord@gmail.com> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <mattalord@gmail.com> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly skip new linter check Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * Fix test file merge issues Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Go 1.18.7 to fix error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix lint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix vttablet.txt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web_build to compile production files Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove vars from test Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <notfelineit@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
…test + compressors (#119) (#124) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code * Move used until functions from initialsharding to cluster * Remove vtctl commands * Kill vtworker and SetKeyspaceServedFrom cmd * WaitForDrain related stragglers * Legacy local straggler workflow * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers * Remove vtworker stragglers * Update throttlerservice protobuf * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) * Remove last mentiones of legacy sharding in vtctl * remove binlog_use_v3_resharding_mode * Address review comments * Address review comments * Correct vtgate help output * go fmt * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * generate vtadmin files * cleanup: remove sharding_column_name and sharding_column_type from vtadmin * Merge from main * Fix bad merge conflict resolution * Fix missing 'sharding' import * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor * add external compressor support + builtin additional compressors * wrap external compressor/decompressor * go mod tidy + comments * add copyright notices * add support for builtin engine * Adding test case for buckup compression * Fixing unit test and run mod tidy * Removing unwanted unit tests * Increase timeout of backup tests * fixing linter errors * Change test logic to accomodate running selective tests * removing lint warning * fixing test failure * Removing un-necessary test * Fixing code review feeback * Change builtinEngine to consider 'auto' decompressor * fixing Upgrade/Downgrade test * Fix type & add summary under release notes * Fixing typos in summary * Fixing flag name typos * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests * Add 8.0 workflow * whitespace * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. * Remove extraneous changes * We need lz4 for TestXtrabackupStreamWithlz4Compression * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions * Specify stream type everywhere * Remove repeated server install * Moar... * Move vtctlbackup test to 8.0 * Rename vtbackup test and move to MySQL 8 * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. * Use MySQL 8 compat method for setting passwords * Test increasing timeout at another level * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. * Fix incorrect password update statement for vt_repl user * Bump timeouts for 8.0 backup tests * Bump it more :( * Increase backup/restore timeout in backup_utils * Apply new 8.0 template everywhere * Fix bugs around how the compression flags were getting passed * Use 45m timeout for the workflow, 30m for the run. * These changes were no longer needed so limiting diff. * Explicitly skip new linter check * Fix test file merge issues * Go 1.18.7 to fix error * Fix lint * Fix vttablet.txt * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type * Run make web_build to compile production files * Remove vars from test * Remove sharding column type select box test from web test --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
Description
This PR backports the deprecation of legacy resharding functionality from v15
Backporting this early has 3 x benefits:
Cluster (shardedrecovery_stress_verticalsplit_heavy)
vtorc
depend on these PRs to be mergedcc @ejortegau to validate that we are not using legacy resharding (
vtworker
-based/no VReplication) functionality:SplitClone
)VerticalSplitClone
)If we are using legacy resharding, it's about to be removed in v15 😅
Related PR(s)
Checklist
Deployment Notes