slack-vitess-r14.0.5: backport vitessio/vitess#10619 pflag migration
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to `pflag` for all parsing This transparently swaps the cli parsing library used by `internal/flag` from the standard library `flag` package to `spf13/pflag`. It also introduces hook points for packages throughout the vitess codebase to register their flags for either all commands using `servenv` or a particular subset of commands. This allows these packages to continue to define their flag variables in a package-private way, but without polluting the global flagset. Signed-off-by: Andrew Mason <andrew@planetscale.com> * Workaround exit code difference between stdlib `flag` and `pflag` tl;dr stdlib `flag` has [this][1] and `pflag` does not [1]: golang/go@dcf0929 Signed-off-by: Andrew Mason <andrew@planetscale.com> * adjust test data for difference in spacing between pflag/stdflag Signed-off-by: Andrew Mason <andrew@planetscale.com> * update lingering legacy flag tests Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update vtgate/tabletgateway.go to use new interface to isolate flags, update test data Signed-off-by: Andrew Mason <andrew@planetscale.com> * update flags in java test code Signed-off-by: Andrew Mason <andrew@planetscale.com>
|
Thanks for the contribution! Before we can merge this, we need @ajm188 to sign the Salesforce Inc. Contributor License Agreement. |
…port-10619-slack-vitess-r14.0.5
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR was closed because it has been stale for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports vitessio#10619 (from v15) in order to reduce friction backporting
txthrottlerandvtorcbackports from v15+, where pflag is used for all command line flag parsingCurrently a significant amount of time backporting > v14 PRs is spent bridging the gap that vitessio#10619 causes. Backporting the
pflagmigration will help us reduce some backporting toilcc @ejortegau
Related Issue(s)
vitessio#10619
Checklist
Deployment Notes