Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make an option to not reuse conns #334

Closed
wants to merge 1 commit into from

Conversation

demmer
Copy link
Collaborator

@demmer demmer commented May 7, 2024

Description

Make an option to not reuse conns.

This required some refactoring so that the interface between the proxy and the mysql server uses a struct that wraps the vtgateconn as well as the session, all so that we can call Close on the conn when the mysql server thread completes.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

This required some refactoring so that the interface between the proxy and the
mysql server uses a struct that wraps the vtgateconn as well as the session,
all so that we can call Close on the conn when the mysql server thread
completes.
Copy link

github-actions bot commented Jun 7, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Jun 7, 2024
Copy link

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant