Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r14.0.5-dsdefense: backport txthrottler cleanup PR vitessio/vitess#12901 #83

Merged
merged 2 commits into from
May 12, 2023
Merged

slack-vitess-r14.0.5-dsdefense: backport txthrottler cleanup PR vitessio/vitess#12901 #83

merged 2 commits into from
May 12, 2023

Commits on May 12, 2023

  1. Cleanup panics in txthrottler, reorder for readability (vitessio#12901 

    )

* Cleanup tx_throttler.go

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Cleanup tx_throttler.go #2

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix throttlerFactoryFunc

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Undo if-cond consolidation

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Undo struct shuffling

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* prove that disabled config returns nil error

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Improve test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed May 12, 2023
    Configuration menu
    Copy the full SHA
    255716f View commit details
    Browse the repository at this point in the history

  2. remove unused cell string

    @timvaillancourt
    timvaillancourt committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6596287 View commit details
    Browse the repository at this point in the history