-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go slack vitess r14.0.5 #91
Upgrade go slack vitess r14.0.5 #91
Commits on Jun 13, 2023
-
Cleanup usage of go.rice in favor of go:embed (vitessio#10956)
* Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d3faec8 - Browse repository at this point
Copy the full SHA d3faec8View commit details -
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 31547b2 - Browse repository at this point
Copy the full SHA 31547b2View commit details
Commits on Jun 14, 2023
-
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 9d45344 - Browse repository at this point
Copy the full SHA 9d45344View commit details -
update the workflows to 1.19.10
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 5d9188b - Browse repository at this point
Copy the full SHA 5d9188bView commit details -
update the docker image to 1.19.10
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 56aaa6d - Browse repository at this point
Copy the full SHA 56aaa6dView commit details -
update the bootstrap version to get docker to go 1.20.5
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for fa52472 - Browse repository at this point
Copy the full SHA fa52472View commit details
Commits on Jun 15, 2023
-
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for c02c548 - Browse repository at this point
Copy the full SHA c02c548View commit details -
lower the build version requirement to allow static checks to pass
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for e770226 - Browse repository at this point
Copy the full SHA e770226View commit details -
experiment with using old and new Go for a single workflow
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for de79026 - Browse repository at this point
Copy the full SHA de79026View commit details
Commits on Jun 16, 2023
-
use old and new Go for a upgrade/downgrade workflows
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for ca7ab2a - Browse repository at this point
Copy the full SHA ca7ab2aView commit details
Commits on Jun 17, 2023
-
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 84bc4a0 - Browse repository at this point
Copy the full SHA 84bc4a0View commit details
Commits on Jun 21, 2023
-
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for a437d2c - Browse repository at this point
Copy the full SHA a437d2cView commit details
Commits on Jul 5, 2023
-
Revert "fix parameter name (#93)" (#100)
This reverts commit 76159fd.
Roderick Yao committedJul 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 4f4d47a - Browse repository at this point
Copy the full SHA 4f4d47aView commit details
Commits on Jul 10, 2023
-
apply patch 12178 to v14 (#102)
Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 82cf45b - Browse repository at this point
Copy the full SHA 82cf45bView commit details
Commits on Jul 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5061df8 - Browse repository at this point
Copy the full SHA 5061df8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d4bff8 - Browse repository at this point
Copy the full SHA 6d4bff8View commit details
Commits on Jul 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ffa760 - Browse repository at this point
Copy the full SHA 5ffa760View commit details -
Merge branch 'upgrade-go-slack-vitess-r14.0.5' of github.com:slackhq/…
…vitess into upgrade-go-slack-vitess-r14.0.5 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Configuration menu - View commit details
-
Copy full SHA for 30ea745 - Browse repository at this point
Copy the full SHA 30ea745View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4cd5a - Browse repository at this point
Copy the full SHA 7c4cd5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff71948 - Browse repository at this point
Copy the full SHA ff71948View commit details
Commits on Aug 2, 2023
-
Ejortegau/larger runners (#115)
* Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use runner group instead Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rename group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Configuration menu - View commit details
-
Copy full SHA for b37228a - Browse repository at this point
Copy the full SHA b37228aView commit details
Commits on Aug 3, 2023
-
Revert change of runner type for shardedrecovery_stress_verticalsplit…
…_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 10c8515 - Browse repository at this point
Copy the full SHA 10c8515View commit details
Commits on Aug 7, 2023
-
slack-vitess-r14.0.5
: use dedicated larger runner (#113)* `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Configuration menu - View commit details
-
Copy full SHA for 5e942b5 - Browse repository at this point
Copy the full SHA 5e942b5View commit details -
slack-vitess-r14.0.5
: allow conn overrides in consul topo (#111)* `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Configuration menu - View commit details
-
Copy full SHA for 7dc3474 - Browse repository at this point
Copy the full SHA 7dc3474View commit details
Commits on Aug 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cc27630 - Browse repository at this point
Copy the full SHA cc27630View commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 472435d - Browse repository at this point
Copy the full SHA 472435dView commit details