Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go slack vitess r14.0.5 #91

Merged

Commits on Jun 13, 2023

  1. Cleanup usage of go.rice in favor of go:embed (vitessio#10956)

    * Cleanup usage of go.rice in favor of go:embed
    
    The usage of go.rice predates the availability of go:embed, but we
    should switch to using go:embed instead to ship specific assets like
    config files that we need.
    
    go.rice is also incompatible with Go 1.19 and while it might see a fix
    in the future, it seems better to go with the recommended Go approach
    that is available these days.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    
    * Move vtctld to also use `go embed` instead of go.rice
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    
    * Remove last rice-box related comments
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    
    * Remove config moving
    
    This right now breaks building the actual tests since the tests might
    also end up loading the regular code which has a `go embed` and refers
    to the package with the config embeds.
    
    This doesn't mean that the config isn't properly included in the
    binaries. Also with using `go embed` we have a build time dependency on
    the files and we always know the latest is included, so we don't have
    the issue of potentially outdated files either.
    
    All in all, it seems simplest to remove this logic and trust that Go
    itself works as advertised.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink authored and maksimov committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d3faec8 View commit details
    Browse the repository at this point in the history
  2. fix vtrootbin

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    31547b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. update the build to 1.19.10

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9d45344 View commit details
    Browse the repository at this point in the history
  2. update the workflows to 1.19.10

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5d9188b View commit details
    Browse the repository at this point in the history
  3. update the docker image to 1.19.10

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    56aaa6d View commit details
    Browse the repository at this point in the history
  4. update the bootstrap version to get docker to go 1.20.5

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    fa52472 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. use 1.18.7 for static checks

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c02c548 View commit details
    Browse the repository at this point in the history
  2. lower the build version requirement to allow static checks to pass

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e770226 View commit details
    Browse the repository at this point in the history
  3. experiment with using old and new Go for a single workflow

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    de79026 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. use old and new Go for a upgrade/downgrade workflows

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ca7ab2a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. set -buildvcs=false

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    84bc4a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. address build errors

    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a437d2c View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Revert "fix parameter name (#93)" (#100)

    This reverts commit 76159fd.
    Roderick Yao committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4f4d47a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. apply patch 12178 to v14 (#102)

    Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
    Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>
    pbibra committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    82cf45b View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Configuration menu
    Copy the full SHA
    5061df8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d4bff8 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    5ffa760 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'upgrade-go-slack-vitess-r14.0.5' of github.com:slackhq/…

    …vitess into upgrade-go-slack-vitess-r14.0.5
    
    Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
    maksimov committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    30ea745 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c4cd5a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff71948 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Ejortegau/larger runners (#115)

    * Empty commit to trigger CI
    
    Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
    
    * `slack-vitess-r14.0.5-dsdefense`: use larger runner
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * Use runner group instead
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * Rename group
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * Move more jobs to runner group
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * use vitess-ubuntu20 runner group
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * Rever change of runner type for e2e ERS PRS new features heavy test
    
    Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
    
    ---------
    
    Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
    ejortegau and timvaillancourt committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b37228a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Revert change of runner type for shardedrecovery_stress_verticalsplit…

    …_heavy. (#116)
    
    We do this because the test is taking a lot longer & failing in some cases with
    the larger runner.
    
    Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
    ejortegau committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    10c8515 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. slack-vitess-r14.0.5: use dedicated larger runner (#113)

    * `slack-vitess-r14.0.5`: use dedicated larger runner
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * fix fileNameFromPosition
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * empty commit
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * empty commit
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    ---------
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    timvaillancourt committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    5e942b5 View commit details
    Browse the repository at this point in the history
  2. slack-vitess-r14.0.5: allow conn overrides in consul topo (#111)

    * `slack-vitess-r14.0.5`: allow conn overrides in consul topo
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    * fix e2e test
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    
    ---------
    
    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    timvaillancourt committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    7dc3474 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Configuration menu
    Copy the full SHA
    cc27630 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    472435d View commit details
    Browse the repository at this point in the history