Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node information on pydm gui #912

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix node information on pydm gui #912

merged 1 commit into from
Feb 14, 2023

Conversation

slacrherbst
Copy link
Contributor

This fixes the node information crash and also adds the full remote variable address as a new field in remove information.

@codecov-commenter
Copy link

Codecov Report

Merging #912 (e624a27) into pre-release (254f84e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@               Coverage Diff               @@
##           pre-release     #912      +/-   ##
===============================================
- Coverage        24.40%   24.38%   -0.02%     
===============================================
  Files               71       71              
  Lines             7752     7758       +6     
  Branches          1167     1168       +1     
===============================================
  Hits              1892     1892              
- Misses            5725     5731       +6     
  Partials           135      135              
Impacted Files Coverage Δ
python/pyrogue/pydm/tools/node_info_tool.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bengineerd bengineerd merged commit 7fedc64 into pre-release Feb 14, 2023
@bengineerd bengineerd deleted the ESROGUE-609 branch February 14, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants