Move zmqServer, sqlLogger and streamMaster out of Root class #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## rogue_v6 #931 +/- ##
============================================
- Coverage 29.66% 29.52% -0.15%
============================================
Files 65 66 +1
Lines 6853 6903 +50
Branches 1069 1061 -8
============================================
+ Hits 2033 2038 +5
- Misses 4657 4708 +51
+ Partials 163 157 -6
|
bengineerd
reviewed
Apr 25, 2023
| @@ -95,20 +104,11 @@ def insert_from_q(self, entry, conn): | |||
| path=entry[0], | |||
| enum=str(entry[1].enum), | |||
| disp=entry[1].disp, | |||
| value=value, | |||
| value=str(value), | |||
There was a problem hiding this comment.
It would be useful to store real values in the DB if possible. SQLite allows non-conforming types, so the value column could have int, float or string depending on the row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future the Root class will be interface agnostic. As such it is not appropriate to continue to support a Root resident ZmqServer, SqlLogger or StreamMaster interface. Instead these will be treated as generic variableListeners which are created separately and added to the root class.
For a transition period the previous methods will be support with deprecation warnings generated when the legacy methods for creating these interfaces are used.
This new method will allow for more customization of these interfaces, as well as adding new interfaces, streamers and loggers to the Root class.
This is a RogueV6 Change.