Remove block to block overlap support #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## rogue_v6 #934 +/- ##
============================================
+ Coverage 25.86% 26.34% +0.47%
============================================
Files 70 70
Lines 7693 7680 -13
Branches 1155 1154 -1
============================================
+ Hits 1990 2023 +33
+ Misses 5543 5494 -49
- Partials 160 163 +3
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ruck314
approved these changes
Apr 24, 2023
bengineerd
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes block to block overlap support. Having two blocks own the same memory space is dangerous and can create unpredictable behavior.
The overlapEn flag is still supported on variables allowing two variables to overlap the same space in a single block. The current block implementation allows to this be supported safely with proper update notification when the underlying memory space changes.
This is a rogueV6 change.