Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values to data writer #947

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

slacrherbst
Copy link
Contributor

This adds the ability to provide default values for bufferSize and maxFileSize to the DataWriter class.

This also removes the fields from the pydm widget as the previous method to conditionally include the fields was not working.

@codecov-commenter
Copy link

Codecov Report

Merging #947 (acb426e) into pre-release (f8174c3) will increase coverage by 0.46%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           pre-release     #947      +/-   ##
===============================================
+ Coverage        25.54%   26.01%   +0.46%     
===============================================
  Files               72       72              
  Lines             7849     7835      -14     
  Branches          1173     1169       -4     
===============================================
+ Hits              2005     2038      +33     
+ Misses            5683     5633      -50     
- Partials           161      164       +3     
Impacted Files Coverage Δ
python/pyrogue/pydm/widgets/data_writer.py 0.00% <ø> (ø)
python/pyrogue/_DataWriter.py 35.13% <100.00%> (ø)

... and 2 files with indirect coverage changes

@slacrherbst slacrherbst merged commit a6f100e into pre-release May 19, 2023
@slacrherbst slacrherbst deleted the data_writer_changes branch May 19, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants