Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyDM Interface Cleanup And Show Example GUI #948

Merged
merged 9 commits into from
May 19, 2023

Conversation

slacrherbst
Copy link
Contributor

@slacrherbst slacrherbst commented May 19, 2023

This PR cleans up the PYDM interface and displays the example .ui GUI which includes demonstrations of Rogue specific pydm widgets when running the following command:

python -m pyrogue.examples --gui

The setup.py file was cleaned up to auto find packages in the tree as well as include the .ui file in the distribution.

The pydm interface now passes a figure object directly instead of pickling it through the interface.

Fixes were made to TimePlot to deal with guiGroups.

The local conda.yml file now limits the pydm version correctly.

This PR also seems to have addresses the memory leak when displaying rogue generated figures in pydm.

@codecov-commenter
Copy link

Codecov Report

Merging #948 (42afe87) into pre-release (f8174c3) will increase coverage by 0.38%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           pre-release     #948      +/-   ##
===============================================
+ Coverage        25.54%   25.93%   +0.38%     
===============================================
  Files               72       72              
  Lines             7849     7859      +10     
  Branches          1173     1175       +2     
===============================================
+ Hits              2005     2038      +33     
+ Misses            5683     5657      -26     
- Partials           161      164       +3     
Impacted Files Coverage Δ
python/pyrogue/examples/_ExampleRoot.py 0.00% <0.00%> (ø)
python/pyrogue/examples/__main__.py 0.00% <0.00%> (ø)
python/pyrogue/pydm/data_plugins/rogue_plugin.py 0.00% <0.00%> (ø)
python/pyrogue/pydm/widgets/plot.py 0.00% <0.00%> (ø)
python/pyrogue/pydm/widgets/time_plotter.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@slacrherbst slacrherbst merged commit 4685491 into pre-release May 19, 2023
@slacrherbst slacrherbst deleted the example_features branch May 19, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants