Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace cleanup #949

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Whitespace cleanup #949

merged 7 commits into from
Jun 28, 2023

Conversation

bengineerd
Copy link
Contributor

@bengineerd bengineerd commented May 22, 2023

Description

This gives every file a consistent whitespace formatting.

It also cleans up the order of #inculde statements in each file.

Results are not always perfect. In particular, the boost-python declarations tend to run up awkwardly against the ColumnLimit: 120, and it doesn't really know how to format them better.

Details

The following commands were run...

> find . -type f -name "*.cpp" -print0 | xargs -0 sed -i -E 's/<(rogue\/.*)>/\"\1\"/'
> find . -type f -name "*.h" -print0 | xargs -0 sed -i -E 's/<(rogue\/.*)>/\"\1\"/'
> clang-format -i **/*.cpp **/*.h

JIRA

https://jira.slac.stanford.edu/browse/ESROGUE-554

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #949 (5524dc8) into rogue_v6 (97ea39c) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##           rogue_v6     #949   +/-   ##
=========================================
  Coverage     29.65%   29.65%           
=========================================
  Files            66       66           
  Lines          6870     6870           
  Branches       1060     1060           
=========================================
  Hits           2037     2037           
  Misses         4674     4674           
  Partials        159      159           

@bengineerd bengineerd marked this pull request as ready for review June 12, 2023 16:01
@bengineerd bengineerd changed the title Lint v6 Whitespace cleanup Jun 12, 2023
@bengineerd bengineerd merged commit 8e3e879 into rogue_v6 Jun 28, 2023
@slacrherbst slacrherbst deleted the lint_v6 branch June 30, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants