Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated features #950

Merged
merged 17 commits into from
Jun 28, 2023
Merged

Remove deprecated features #950

merged 17 commits into from
Jun 28, 2023

Conversation

slacrherbst
Copy link
Contributor

This PR removes the last of the deprecated features in preparation for Rogue V6.

Removed deprecated features include:

  • RawRead / RawWrite
  • Background commands
  • ZmqServer in Root class
  • SqlLogger in Root class
  • Configuration streaming from Root class

@slacrherbst slacrherbst changed the title Remote deprecated features Remove deprecated features Jun 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #950 (e88bbfa) into rogue_v6 (f97abe0) will increase coverage by 0.13%.
The diff coverage is 16.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           rogue_v6     #950      +/-   ##
============================================
+ Coverage     29.67%   29.80%   +0.13%     
============================================
  Files            66       66              
  Lines          6872     6724     -148     
  Branches       1060     1035      -25     
============================================
- Hits           2039     2004      -35     
+ Misses         4674     4564     -110     
+ Partials        159      156       -3     
Impacted Files Coverage Δ
python/pyrogue/_Device.py 52.29% <0.00%> (+5.73%) ⬆️
python/pyrogue/_HelperFunctions.py 32.75% <ø> (-0.20%) ⬇️
python/pyrogue/_Root.py 54.42% <0.00%> (+3.22%) ⬆️
python/pyrogue/_Variable.py 60.23% <ø> (-0.09%) ⬇️
python/pyrogue/protocols/_uart.py 17.85% <ø> (-0.75%) ⬇️
python/pyrogue/protocols/epicsV4.py 52.51% <ø> (+0.04%) ⬆️
python/pyrogue/pydm/__init__.py 0.00% <0.00%> (ø)
python/pyrogue/_Command.py 52.86% <100.00%> (-1.31%) ⬇️

... and 1 file with indirect coverage changes

@slacrherbst slacrherbst merged commit a561ab5 into rogue_v6 Jun 28, 2023
5 checks passed
@slacrherbst slacrherbst deleted the rem_raw branch June 28, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants