Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nodeList recursive to match deviceList and variableList #954

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

slacrherbst
Copy link
Contributor

Make nodeList recursive to match deviceList and variableList

@codecov-commenter
Copy link

Codecov Report

Merging #954 (12cd03f) into pre-release (4685491) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           pre-release     #954      +/-   ##
===============================================
- Coverage        25.97%   25.96%   -0.02%     
===============================================
  Files               72       72              
  Lines             7845     7849       +4     
  Branches          1171     1171              
===============================================
  Hits              2038     2038              
- Misses            5643     5647       +4     
  Partials           164      164              
Impacted Files Coverage Δ
python/pyrogue/_Node.py 54.95% <0.00%> (-0.63%) ⬇️

@bengineerd
Copy link
Contributor

I guess if you want a non-recursive list you just do

list(self.nodes.items())

@slacrherbst slacrherbst merged commit 4f86fe2 into pre-release Jun 29, 2023
5 checks passed
@slacrherbst slacrherbst deleted the ESROGUE-599 branch June 29, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants