Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset fifo counters when countReset chain is called #960

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

slacrherbst
Copy link
Contributor

Reset fifo counters when countReset chain is called

@slacrherbst slacrherbst changed the title Creset Reset fifo counters when countReset chain is called Aug 7, 2023
@ruck314
Copy link
Contributor

ruck314 commented Aug 7, 2023

@slacrherbst Please review 0fa5a6a

@codecov-commenter
Copy link

Codecov Report

Merging #960 (2fd2ba5) into pre-release (69e0a4b) will increase coverage by 0.00%.
Report is 9 commits behind head on pre-release.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           pre-release     #960   +/-   ##
============================================
  Coverage        29.73%   29.74%           
============================================
  Files               66       66           
  Lines             6739     6741    +2     
  Branches          1039     1039           
============================================
+ Hits              2004     2005    +1     
- Misses            4578     4579    +1     
  Partials           157      157           
Files Changed Coverage Δ
python/pyrogue/_HelperFunctions.py 32.75% <33.33%> (ø)
python/pyrogue/interfaces/stream/_Fifo.py 40.90% <50.00%> (+0.90%) ⬆️
python/pyrogue/_Variable.py 60.23% <100.00%> (ø)

@slacrherbst slacrherbst merged commit d32ab47 into pre-release Aug 8, 2023
5 checks passed
@slacrherbst slacrherbst deleted the creset branch August 8, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants