Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Delay3PatchFSM: init issue (JIRA ESSURF-24) #1089

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

jumdz
Copy link
Contributor

@jumdz jumdz commented Jun 23, 2023

Fixing init bug of the delay3PatchFSM

Description

I added an additional step named CHECK_CNT_S. IT handles the logic previously located in the IDLE_S state. Then, the IDLE_S has been changed to wait for a load command. The FSM goes to CHECK_CNT_S after loading where the logic check if the CNTINVALUE has to be inc/dec. Finally, if the FSM has reached the expect value, it goes back to IDLE_S and wait for a new LOAD_S.

Details

Side effect: no new value can be load until busy signal goes back to low.

JIRA

ESSURF-24

@jumdz jumdz requested review from ruck314 and bengineerd June 23, 2023 21:44
@jumdz jumdz self-assigned this Jun 23, 2023
@ruck314 ruck314 changed the base branch from master to pre-release June 23, 2023 21:45
@ruck314 ruck314 merged commit c755ebe into pre-release Jun 27, 2023
3 checks passed
@ruck314 ruck314 deleted the delay3patch_fix branch June 27, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants