Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SugoiSubordinateFsm.vhd Updates #1169

Merged
merged 3 commits into from
Jun 19, 2024
Merged

SugoiSubordinateFsm.vhd Updates #1169

merged 3 commits into from
Jun 19, 2024

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Jun 19, 2024 •
edited
Loading

Description

  • For ASIC designs it is best to declare a 'Default' state which returns to INIT_S state
    • force INIT_S state if 4-bit r.state is not enum define state
  • removing 'default' on pwrOnRst because it should always be connected on ASIC

@ruck314 ruck314 added the bug label Jun 19, 2024
@ruck314 ruck314 requested a review from lorenzrota June 19, 2024 18:29
@ruck314 ruck314 changed the title SugoiSubordinateFsm.vhd update to force INIT_S state if 4-bit r.state is not enum define state SugoiSubordinateFsm.vhd Updates Jun 19, 2024
@ruck314 ruck314 requested a review from ddoering June 19, 2024 22:11
@ruck314 ruck314 marked this pull request as ready for review June 19, 2024 22:11
@ruck314 ruck314 mentioned this pull request Jun 19, 2024
Merged
ddoering
ddoering approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ddoering ddoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did a code review, and this changes are approved

@ruck314 ruck314 merged commit 91b8189 into pre-release Jun 19, 2024
3 checks passed
@ruck314 ruck314 deleted the SugoiSubordinateFsm-update branch June 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoering ddoering ddoering approved these changes

@lorenzrota lorenzrota Awaiting requested review from lorenzrota

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruck314 @ddoering