Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file_utils): add support for CSV files #185

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

nikaera
Copy link
Contributor

@nikaera nikaera commented Jan 7, 2024

I implemented the encodeContent function so that dart run slang analyze can be used even if csv is used for translation files. I changed the translation file of example project from json to csv and verified that it works 🛠️

key,en,de
mainScreen.title,An English Title,Ein deutscher Titel
mainScreen.counter.one,You pressed $n time.,Du hast einmal gedrückt.
mainScreen.counter.other,You pressed $n times.,Du hast $n mal gedrückt.
mainScreen.tapMe,Tap me,Drück mich
unknownScreen.title,Unknown Title,Unbekannter Titel
key,@@info,en,de
@@info,"Here are translations that exist in secondary locales but not in <en>.\n[--full enabled] Furthermore, translations not used in 'lib/' according to the 't.<path>' pattern are written into <en>.",,
unknownScreen.title,,Unknown Title,

@nikaera
Copy link
Contributor Author

nikaera commented Jan 8, 2024

I fixed the dart format failure in CI and pushed again 🙏
https://github.com/slang-i18n/slang/actions/runs/7436546343/job/20235506409

@nikaera nikaera force-pushed the main branch 2 times, most recently from 2f3cbfa to 3bbce64 Compare January 8, 2024 13:10
@nikaera
Copy link
Contributor Author

nikaera commented Jan 8, 2024

I corrected the wrong commit author and re-committed and force pushed... 🙇 🙏

@Tienisto
Copy link
Member

Tienisto commented Jan 9, 2024

Thank you!

@Tienisto Tienisto merged commit 55b8ea2 into slang-i18n:main Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants