Minor fixes

Minor fixes in integral basis library
slap · Sep 19, 2023 · 9e51a76 · 9e51a76
1 parent 5912bdf
commit 9e51a76
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 7 deletions.
diff --git a/Singular/LIB/.singularhistory b/Singular/LIB/.singularhistory
@@ -1068,5 +1068,27 @@ ring r = 0,(x,y),dp;
 poly f = x^15-21*x^14+8*x^13*y-6*x^13-16*x^12*y+20*x^11*y^2-x^12+8*x^11*y-36*x^10*y^2+24*x^9*y^3+4*x^9*y^2-16*x^8*y^3+26*x^7*y^4-6*x^6*y^4+8*x^5*y^5+4*x^3*y^6-y^8;
 f = f *(-1);
 list l = integralBasis(f, 2, "nonModular");
-
 l;
+LIB"integralbasis.lib";
+ring r = 0,(x,y),dp;
+poly f = (y^4 + 2*x^3*y^2 + x^6 + x^5*y)^3 + x^11*y^11;
+list l = integralBasis(f, 2, "nonModular");
+l;
+LIB"integralbasis.lib";
+ring r = 0,(x,y),dp;
+poly f = (y^4 + 2*x^3*y^2 + x^6 + x^5*y)^3 + x^11*y^11;
+list l = integralBasis(f, 2, "nonModular");
+LIB"integralbasis.lib";
+ring r = 0, (x,y), dp;
+poly f = (y3+x2)*(y2-x3)+y6;
+integralBasis(f,2);
+LIB"integralbasis.lib";
+ring r = 0, (x,y), dp;
+poly f = (y7 + x4) * (y7 + y6x + x4)*(y7 + y5x3 + x4)+y30;
+int t = timer;
+list l1 = integralBasis(f,2, "atOrigin");
+LIB"integralbasis.lib";
+ring r = 0, (x,y), dp;
+poly f = (y7 + x4) * (y7 + y5x3 + x4)+y30;
+list l2 = integralBasis(f,2, "atOrigin", "noOpti");
+
diff --git a/Singular/LIB/integralbasis.lib b/Singular/LIB/integralbasis.lib
@@ -2335,10 +2335,8 @@ proc buildPolyGroundXRoot(poly f, int den)
     //~;
 
     list pols;
-    poly ff;
     for(i = 1; i <= den; i++)
     {
-
       ff = subst(ffRed, var(1), var(1) * var(2+i));
       pols[i] = ff;
     }
@@ -2361,13 +2359,14 @@ proc buildPolyGroundXRoot(poly f, int den)
     }
     I = groebner(I);
 
-    poly fNewTemp = 1;
+    poly fNew = 1;
     for(i = 1; i<=den; i++)
     {
-      fNewTemp = fNewTemp * (var(2) - pols[i]);
-      fNewTemp = reduce(fNewTemp, I);
+      fNewTemp = fNew * (var(2) - pols[i]);
+      fNew = reduce(fNewTemp, I);
     }
-    poly fNew = reduce(fNewTemp, I);
+    //poly fNew = reduce(fNewTemp, I);
+    //poly fNew = fNewTemp;
 
     //"fNewTemp", pols, den;
     //~;