-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve the bottom-of-the-page bug #280
Comments
This wouldn't be a problem in real-world use, I think — do we expect people will publish API docs that are less than a screen of text, yet use slate to do that? |
@ryw well, only the very last section of the document would have to be less than the entire page, which is something I see somewhat often. |
Would love to see a fix to this problem. Totally agree that it is encountered in real-world use. |
Got it - working on our slate docs site for http://astronomer.io over the next week or two, I'm happy to have a look at this, give back to a cool project ;) |
@ryw 😄 Thanks for offering to help! Just as a warning, right now in the |
Just thought I'd pipe up with some input/another case (I may be wrong, but I believe I am experiencing this issue on my slate docs pages). Steps to reproduce:
Steps to get "Previous Versions" to highlight when selected:
Sometimes this won't work, and you'll have to click one of the last items in the nav menu a few times before the bottom links in the nav start highlighting correctly. |
An addition of a footer would be nice. See how readme.io does this https://sample-threes.readme.io/ |
* Add showing/hiding submenus, fix sidebar styling, fix bug where includes wouldn't appear in ToC * Update ToC to highlight last header if page is scrolled to very bottom, fixes #280 * Set HTML title to current h1 section text, see #133 * Fix menu not opening on mobile * Add back increase toc item height on mobile * Fix padding bug * Add back in ToC sliding animation
Fixed in the |
The thing where you can't get to the bottom item of the ToC if there's not enough content:
Ideas:
The text was updated successfully, but these errors were encountered: