Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the bottom-of-the-page bug #280

Closed
lord opened this issue Jun 20, 2015 · 8 comments
Closed

Solve the bottom-of-the-page bug #280

lord opened this issue Jun 20, 2015 · 8 comments

Comments

@lord
Copy link
Member

lord commented Jun 20, 2015

The thing where you can't get to the bottom item of the ToC if there's not enough content:

image

Ideas:

  • Add a page-tall footer with a gigantic picture of a cat
  • Adjust the distance from the top that the 'current' item has as the page scrolls
  • Something else crazy and magical?
@lord lord added this to the Version 2 milestone Jun 20, 2015
@ryw
Copy link

ryw commented Jun 20, 2015

This wouldn't be a problem in real-world use, I think — do we expect people will publish API docs that are less than a screen of text, yet use slate to do that?

@lord
Copy link
Member Author

lord commented Jun 20, 2015

@ryw well, only the very last section of the document would have to be less than the entire page, which is something I see somewhat often.

@WorkForPizza
Copy link

Would love to see a fix to this problem. Totally agree that it is encountered in real-world use.

@ryw
Copy link

ryw commented Jun 22, 2015

Got it - working on our slate docs site for http://astronomer.io over the next week or two, I'm happy to have a look at this, give back to a cool project ;)

@lord
Copy link
Member Author

lord commented Jun 22, 2015

@ryw 😄 Thanks for offering to help! Just as a warning, right now in the v2 branch that I'm working in, the table of contents is pretty broken (since I'm removing our Tocify dependency). But feel free to make PRs to that branch if you find anything that works well!

@oubiwann
Copy link

Just thought I'd pipe up with some input/another case (I may be wrong, but I believe I am experiencing this issue on my slate docs pages).

Steps to reproduce:

  • Visit http://lfex.github.io/lhc/current/
  • Click on link towards the bottom of the nav (do not click the last one, though). For instance, click "Previous Versions"
  • Observe that "Backends -> Backend Information" is actually highlighted, not "Previous Versions"

Steps to get "Previous Versions" to highlight when selected:

  • Refresh page
  • Click the last item in the nav menu
  • Click "Previous Versions" -- it should now be highlighted

Sometimes this won't work, and you'll have to click one of the last items in the nav menu a few times before the bottom links in the nav start highlighting correctly.

@axilleas
Copy link

An addition of a footer would be nice. See how readme.io does this https://sample-threes.readme.io/

@lord lord removed this from the Version 2 milestone Jan 26, 2016
@lord lord mentioned this issue Feb 24, 2017
8 tasks
lord added a commit that referenced this issue Feb 24, 2017
* Add showing/hiding submenus, fix sidebar styling, fix bug where includes wouldn't appear in ToC

* Update ToC to highlight last header if page is scrolled to very bottom, fixes #280

* Set HTML title to current h1 section text, see #133

* Fix menu not opening on mobile

* Add back increase toc item height on mobile

* Fix padding bug

* Add back in ToC sliding animation
@lord
Copy link
Member Author

lord commented Feb 24, 2017

Fixed in the dev branch with the new table of contents! 😸

@lord lord closed this as completed Feb 24, 2017
ketan referenced this issue in ketan/api.go.cd Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants