Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: POC: new usage framework #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

slaviered
Copy link
Owner

Assisted Pull Request

Description

Changes to the usage library:

  1. Added Registry so different object can sign in their usage report in a standard fashion instead of the ad-hoc functions that spread all over the code
  2. Changed the API from simple CRUD to single Set that handles the basic logic in one place + handle transactions within the usage library instead of from outside
  3. Add categories so usage can be reported in the inventory in a generic way (as long as there is no new category) and new usages are simply added to the category arrays and served automatically

List all the issues related to this PR

  • New Feature
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @
/cc @

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant