-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded to support @apollo/server 4.4.1 #41
base: master
Are you sure you want to change the base?
Conversation
Hi @t2y @slaypni , as @geoyws mentioned, thank you for maintaining this library. It truly is a gem! I was wondering if there are any updates on the state of this PR? My team is migrating to Apollo Server v4 and incompatibility with this library is the only thing preventing us from migrating. Would appreciate any updates. Again, thank you for the support and this PR! |
@RodoVJ perhaps you could fork and apply the changes on my pull request while we wait for the merge. My team has been actually going into the node_modules and applying these changes manually each time we pnpm install (if from scratch). 😅 |
Thanks for the suggestion @geoyws 😅. We might resort to doing what your team is currently doing if we don't hear anything back soon :) |
My sincere apologies @slaypni , I didn't run the tests after putting in this PR. |
We all are waiting for your PR! )) |
Can we please get this merged in? |
@geoyws, thanks for your implementation of the new apollo v4 plugin. |
Finally! After half a year of marathon work on my main job I finally have the time to run tests here and make sure they're passing. Sorry again everyone. The tests are passing now so if the changes are acceptable, please consider accepting! 🙏🏼 |
Do give this a try and let me know if it works! Basically we just have to change the Apollo plugin's read and write to
contextValue
instead ofcontext
. @slaypni @t2y Thanks so much for maintaining this gem of a library. It really saves my team a lot of time. 🙏