SlevomatCodingStandard.Strings.DisallowVariableParsing: Fixed false p…

…ositive
slevomat · Apr 14, 2023 · 3cddc97 · 3cddc97
1 parent 5945d69
commit 3cddc97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/SlevomatCodingStandard/Sniffs/Strings/DisallowVariableParsingSniff.php b/SlevomatCodingStandard/Sniffs/Strings/DisallowVariableParsingSniff.php
@@ -21,7 +21,7 @@ class DisallowVariableParsingSniff implements Sniff
 
 	private const DOLLAR_CURLY_SYNTAX_PATTERN = '~\${[\w\[\]]+}~';
 	private const CURLY_DOLLAR_SYNTAX_PATTERN = '~{\$[\w\[\]\->]+}~';
-	private const SIMPLE_SYNTAX_PATTERN = '~(?<!{)\$[\w\[\]\->]+(?!})~';
+	private const SIMPLE_SYNTAX_PATTERN = '~(?<!{|\[)\$[\w\[\]\->]+(?!})~';
 
 	/** @var bool */
 	public $disallowDollarCurlySyntax = true;

diff --git a/tests/Sniffs/Strings/data/disallowVariableParsingErrors.php b/tests/Sniffs/Strings/data/disallowVariableParsingErrors.php
@@ -47,3 +47,5 @@
 Some heredoc line with array item variable $array[1]
 Some heredoc line with object variable $object->name
 EOT;
+
+"{$array[$simpleString]}";