SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration: Fixed …

…false positive for final constant
slevomat · Sep 4, 2023 · 789275d · 789275d
1 parent fd2b381
commit 789275d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/SlevomatCodingStandard/Sniffs/Commenting/InlineDocCommentDeclarationSniff.php b/SlevomatCodingStandard/Sniffs/Commenting/InlineDocCommentDeclarationSniff.php
@@ -23,6 +23,7 @@
 use const T_CONST;
 use const T_DOC_COMMENT_OPEN_TAG;
 use const T_EQUAL;
+use const T_FINAL;
 use const T_FN;
 use const T_FOREACH;
 use const T_LIST;
@@ -89,7 +90,7 @@ public function process(File $phpcsFile, $commentOpenPointer): void
 
 			if (in_array(
 				$tokens[$pointerAfterCommentClosePointer]['code'],
-				[T_PRIVATE, T_PROTECTED, T_PUBLIC, T_READONLY, T_CONST],
+				[T_PRIVATE, T_PROTECTED, T_PUBLIC, T_READONLY, T_FINAL, T_CONST],
 				true
 			)) {
 				return;

diff --git a/tests/Sniffs/Commenting/data/noInvalidInlineDocCommentDeclarations.php b/tests/Sniffs/Commenting/data/noInvalidInlineDocCommentDeclarations.php
@@ -1,4 +1,4 @@
-<?php // lint >= 8.1
+<?php // lint >= 8.2
 
 /**
  * @var string
@@ -33,6 +33,14 @@ class Foo
 	/** @var string */
 	static $static;
 
+	/**
+	 * @var list<MyEnum> For PHPStorm
+	 */
+	final public const ENUM_LIST = [
+		MyEnum::One,
+		MyEnum::Two,
+	];
+
 	public function __construct()
 	{
 		/** @var string[] $a */