Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sniff AlphabeticallySortedUses sorts alphabetically also functions #47

Closed
janedbal opened this issue Jul 21, 2016 · 4 comments
Closed

Comments

@janedbal
Copy link
Contributor

I know this it not so common, but this sniff behaves differently then optimizing use statements for example in PhpStorm. I don't know if this is intentional so I'm noticing it here.

Expected order by this sniff (strict alphabetical):

use Doctrine\ORM\EntityManager;
use function GuzzleHttp\Psr7\str as format_http_message;
use GuzzleHttp\Exception\RequestException;

Optimized by PhpStorm (functions at the end):

use Doctrine\ORM\EntityManager;
use GuzzleHttp\Exception\RequestException;
use function GuzzleHttp\Psr7\str as format_http_message;
@ondrejmirtes
Copy link
Contributor

ondrejmirtes commented Jul 21, 2016

There is no support for use function and use const because I literally haven't heard about this syntax until now. We will fix it for sure in the future and try to stay compatible with PhpStorm. /cc @pepakriz

@pepakriz
Copy link
Contributor

@ondrejmirtes I agree

@ondrejmirtes
Copy link
Contributor

ondrejmirtes commented Aug 8, 2016

Fixed with ef4c333

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants