Revert "replace squizlabs/php_codesniffer with phpcsstandards/php_codesniffer"

[jrfnl]

Revert "replace squizlabs/php_codesniffer with phpcsstandards/php_codesniffer"

This reverts commit 2713947.

See: #1641 (comment)

Also: https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0

TestCase: update for new Ruleset::$properties format

Related to the handling of the PHP 8.2 dynamic properties deprecation.

Note: this issue will not block end-users, it is only the test suite which is affected.

Refs:

• https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0 (2nd bullet in "Changed")
• PHP 8.2 | Ruleset: prevent notices about dynamic properties being set squizlabs/PHP_CodeSniffer#3629
• PHP 8.2: dynamic properties are deprecated squizlabs/PHP_CodeSniffer#3489

[kukulich]

Thanks.

[janedbal]

Is this really good idea?

I think that since old repo does not contain releases, dependabot summaries are not as good anymore. See e.g. editorconfig-checker/editorconfig-checker.php#298

[janedbal]

And I mean using proper package name in general, not in this particular repository.

[jrfnl]

Is this really good idea?

I think that since old repo does not contain releases, dependabot summaries are not as good anymore. See e.g. editorconfig-checker/editorconfig-checker.php#298

Yes it is. The package name ended up not being changed and Packagist was updated to look at the new repo, so releases will now be taken from the new repo. If Dependabot does not handle this correctly, you need to report a bug there.

For the record, this means that the "proper package name" is still squizlabs/php_codesniffer and any repo which points to phpcsstandards/php_codesniffer should revert that change (and runs the risk of the package at some point not working anymore).

[janedbal]

any repo which points to phpcsstandards/php_codesniffer should revert that change (and runs the risk of the package at some point not working anymore)

Why? Can you describe/link some more details on this topic? Thx

[jrfnl]

any repo which points to phpcsstandards/php_codesniffer should revert that change (and runs the risk of the package at some point not working anymore)

Why? Can you describe/link some more details on this topic? Thx

Because that name will be taken offline as soon as possible, or at the very least marked as abandoned.