This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Kontrola existence cesty k veřejnému klíči #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better for documentation purposes of this test - invalid public key does not affect if pkp can be counted or not
Paths are checked early in constructor, so it can be checked only once on object constructing and close to source of bug.
jost125
force-pushed
the
jm-certificate-checks
branch
2 times, most recently
from
d2c4198 to
a7f5801
Compare
jost125
force-pushed
the
jm-certificate-checks
branch
from
a7f5801 to
b0fb3d6
Compare
janlanger
suggested changes
Feb 26, 2017
| @@ -16,6 +16,12 @@ class CryptographyService | |||
|
|
|||
| public function __construct(string $privateKeyFile, string $publicKeyFile, string $privateKeyPassword = '') | |||
| { | |||
| if (!file_exists($privateKeyFile)) { | |||
There was a problem hiding this comment.
spíš is_file file_exists vrací true i pro adresáře
| } catch (\PHPUnit\Framework\AssertionFailedError $exception) { | ||
| throw $exception; | ||
| } catch (\Throwable $exception) { | ||
| $this->assertInstanceOf($expectedExceptionType, $exception); |
There was a problem hiding this comment.
Tady by se hodilo spíš $this->expectException
| /** | ||
| * @var string | ||
| */ | ||
| private $publicKeyFile; |
| @@ -65,6 +65,7 @@ public function getBkpCode(string $pkpCode): string | |||
|
|
|||
| public function addWSESignature(string $request): string | |||
| { | |||
| $this->tryLoadPublicKey(); | |||
There was a problem hiding this comment.
Asi bych do metody posílal už obsah souboru, nebude se muset načítat 2x.
Přejmenoval bych metodu na verifyPublicKey
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.